Relative "ccls.launch.command" path does not work since 0.1.27

TheMozg commented 5 years ago

Observed behavior

Relative-to-workspace-root path stopped working in version 0.1.27:

    "ccls.launch.command": ".vscode/ccls",

Output panel:

Server CWD is /export/home/fedor.kalugin/repos/tb1
ccls server connection was closed
[Error - 4:24:40 PM] Connection to server got closed. Server will not be restarted.

The binary isn't executed.

Expected behavior

ccls.launch.command is resolved relative to ${workspaceFolder}.

Notes:

I suspect this is after 2a41a8f5d982f70ae09188acb1dcd6a7f31f8f38.

Relative path is useful because it allows me to share the whole .vscode directory as a plug-and-play repo, which my coworkers can clone to get workplace settings and ccls binary without having to edit settings.json manually.

System information

ccls version (git describe --tags): 0.20190314-0-g1976fec
OS: Linux via remote remote-ssh
Editor: 1.39.2
vscode-ccls version (git describe --tags): 0.1.28

MaskRay commented 5 years ago

Do something similar to https://github.com/cquery-project/vscode-cquery/pull/37 ?

A relative executable path seems unusual. Does "ccls.launch.command": "${workspaceFolder}/.vscode/ccls" work?

TheMozg commented 5 years ago

"ccls.launch.command": "${workspaceFolder}/.vscode/ccls" works, thank you.

MaskRay / vscode-ccls