search

MaslowCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
263 stars 134 forks source link

Reword message about arcs #446

Closed BarbourSmith closed 6 years ago

BarbourSmith commented 6 years ago

It seems like this message is giving folks the impression that something has gone wrong when really the machine is being smart and preventing an issue.

I think it makes sense to take out the words oops and error which make perfect sense when you understand the code but which are intimidating if you don't know what is going on

MaslowCommunityGardenRobot commented 6 years ago

Congratulations on the pull request @BarbourSmith!!

Now we need to decide as a community if we want to integrate these changes. You can vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a silly robot, but I love to see people contributing so I'm going vote thumbs up!

blurfl commented 6 years ago

Maybe "large-radius arc" instead of "large arc"?

BarbourSmith commented 6 years ago

I agree. Done!

MaslowCommunityGardenRobot commented 6 years ago

Woo!! Times up and we're ready to merge this pull request! Great work!