search

MaslowCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
261 stars 136 forks source link

Adds a link to a wiki page for when the sled is not keeping up #447

Closed BarbourSmith closed 6 years ago

BarbourSmith commented 6 years ago

Since this error catches most issues we've been getting a lot of folks asking about it in the forums.

The PR adds the URL of a wiki page with more information to the popup. I also removed the words about writing down the line number because the popup occurs both when a program is running and when there is no program running.

I would really like the link to be clickable, but opening a web browser from a popup is pretty tricky so this will have to work for now

MaslowCommunityGardenRobot commented 6 years ago

Congratulations on the pull request @BarbourSmith!!

Now we need to decide as a community if we want to integrate these changes. You can vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a silly robot, but I love to see people contributing so I'm going vote thumbs up!

MaslowCommunityGardenRobot commented 6 years ago

Woo!! Times up and we're ready to merge this pull request! Great work!