search

MaslowCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
263 stars 133 forks source link

B11 should not trigger position error alarm #456

Closed blurfl closed 6 years ago

blurfl commented 6 years ago

The B11 gcode moves a motor at speed S for T seconds. It should not trigger the position error alarm as it is a testing gcode.

Usage example (moves the left motor at speed 200 for 2 seconds: B11 L1 S200 T2

(S)peed accepts a float but treats that as an integer 0..255 (T)ime is a float

MaslowCommunityGardenRobot commented 6 years ago

Congratulations on the pull request @blurfl

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

MaslowCommunityGardenRobot commented 6 years ago

Time is up and we're ready to merge this pull request. Great work!

blurfl commented 5 years ago

That's a good find! A PR to correct that would be great. Very glad to see the details checked, code polished.

esspe2 commented 5 years ago

Hi, Thanks for your nice reply! PR seemed daunting, but I should have managed that by now, back to Git, finally using ssh keys btw. Now, "my" PR #492 seems to include both the guestbook and the change, we'll see if all goes well.

Regards, --Stephane Peters                    

BarbourSmith commented 5 years ago

Great to see you @blurfl, we've missed you 😀