MaslowCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
263 stars 133 forks source link

add missing setting to defaults in Settings:settingsReset() #465

Closed blurfl closed 6 years ago

blurfl commented 6 years ago

settingsReset() does not include a default value for chainLength. Without a value for chainLength, kinematics fails with:

"Message: Unable to find valid machine position for chain lengths "

GC responds by sending it's own setting value ($10), but the kinematics error requires the user to recalibrate the chains.

MaslowCommunityGardenRobot commented 6 years ago

Congratulations on the pull request @blurfl

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

MaslowCommunityGardenRobot commented 6 years ago

Time is up and we're ready to merge this pull request. Great work!