search

MaslowCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
263 stars 133 forks source link

Adjust encoderStep defaults #468

Closed johnboiles closed 6 years ago

johnboiles commented 6 years ago

@madgrizzle will have to chime in on the justification for this change. I just pulled it from his development branch!

MaslowCommunityGardenRobot commented 6 years ago

Congratulations on the pull request @johnboiles

Now we need to decide as a community if we want to integrate these changes. Vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up!

madgrizzle commented 6 years ago

This change came about while trying to figure out why the B02 command is not working properly. The "correct" value for encoder steps is 8113.73 (based upon work from a long while back). In firmware, the default value was 8113.7 and in GC, the default value is 8113.73. GC updates the firmware to set it to 8113.73. However, during troubleshooting the B02 command, I corrected the default value in FW to be 8113.73. It's an innocuous change.

MaslowCommunityGardenRobot commented 6 years ago

Time is up and we're ready to merge this pull request. Great work!