detach() should run once per state change

MaslowCNC / Firmware

Maslow Firmware

GNU General Public License v3.0

263 stars 134 forks source link

detach() should run once per state change #494

Closed blurfl closed 5 years ago

blurfl commented 5 years ago

No need to repeat the operation once it has been accomplished.

MaslowCommunityGardenRobot commented 5 years ago

Congratulations on the pull request @blurfl

Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!

esspe2 commented 5 years ago

Positive vote for me, seems good practice.

MaslowCommunityGardenRobot commented 5 years ago

Time is up and we're ready to merge this pull request. Great work!