Closed blurfl closed 5 years ago
MaslowCommunityGardenRobot
commented
5 years ago Congratulations on the pull request @blurfl
Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.
I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!
blurfl
commented
5 years ago PR#510 and PR#511 aren't compatible with each other, one or the other can be merged but not both. I couldn't see a way to be sure that only one would 'win' merging, so I guess I'll watch the votes and close the one with a lower total. Help with the vote count by giving one a 👍🏻and the other a 👎.
MaslowCommunityGardenRobot
commented
5 years ago It looks like adding these changes right now isn't a good idea. Consider any feedback that the community has given about why not and feel free to open a new pull request with the changes
Explain the zero-based version number reported from the 1-based gpio pin strapping. Continue to use the same 1-based format for pin strapping.
Attempting to implement some of the suggestions in recent discussions:
PR#502 Issue#504 PR#505
There is a parallel/competing PR#51o which updates the comments and changes the version strapping for future boards - choose one or the other with your vote.