search

MaslowCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
263 stars 133 forks source link

Alarm if board version is unrecognized #512

Closed blurfl closed 5 years ago

blurfl commented 5 years ago

• set all gpio pin numbers to 0 • Post an error dialog • loop forever to cause a serial disconnect

Board-unrecognized Alarm message

MaslowCommunityGardenRobot commented 5 years ago

Congratulations on the pull request @blurfl

Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!

BarbourSmith commented 5 years ago

This is a great idea 👍👍

blurfl commented 5 years ago

Credit for the idea goes to @esspe2, from his comment here 👍

Either way, if I were to push my thoughts further, the runtime should stop and yell something like board unrecognized, or version pins configuration unknown.

MaslowCommunityGardenRobot commented 5 years ago

Time is up and we're ready to merge this pull request. Great work!