search

MaslowCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
263 stars 133 forks source link

Resolve comile warning in function maslow ring buffer increment end() #522

Closed blurfl closed 5 years ago

blurfl commented 5 years ago

The compiler posts a warning:

sketch/maslowRingBuffer.cpp: In member function 'int maslowRingBuffer::_incrementEnd()': sketch/maslowRingBuffer.cpp:170:5: warning: this 'else' clause does not guard... [-Wmisleading-indentation] else ^~~~ sketch/maslowRingBuffer.cpp:172:9: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the 'else' return 0; ^~

Make the recommended change.

MaslowCommunityGardenRobot commented 5 years ago

Congratulations on the pull request @blurfl

Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!

MaslowCommunityGardenRobot commented 5 years ago

Time is up and we're ready to merge this pull request. Great work!