search

MaslowCNC / Firmware

Maslow Firmware
GNU General Public License v3.0
263 stars 134 forks source link

New Feature: Z Axis limits to prevent equipment strain #542

Closed ariasr closed 4 years ago

ariasr commented 4 years ago

I have made some small tweaks to the code to be able to set upper and lower limits for the z axis in order to prevent equipment strain.

I have added two variables to settings float zAxisUpperLimit float zAxisLowerLimit

I have created 4 "B" commands B17 Set the z axis upper limit to the current z axis position B18 Set the z axis lower limit to the current z axis position B19 Clear z axis limits B20 Echo z axis limits

I have made some changes to Axis, GCode and Settings classes.

I would like to contribute it to the project.

Best Regards

davidelang commented 4 years ago

once you get the robot e-mail, vote by adding a thumbs up to the robot's post, that will merge your pull request unless people vote thumbs down.

David Lang

On Sun, 17 May 2020, ariasr wrote:

Date: Sun, 17 May 2020 16:10:39 -0700 From: ariasr notifications@github.com Reply-To: MaslowCNC/Firmware reply@reply.github.com To: MaslowCNC/Firmware Firmware@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: [MaslowCNC/Firmware] New Feature: Z Axis limits to prevent equipment damage (#542)

I have made some small tweaks to the code to be able to set upper and lower limits for the z axis in order to prevent equipment strain.

I have added two variables to settings float zAxisUpperLimit float zAxisLowerLimit

I have created 4 "B" commands B17 Set the z axis upper limit to the current z axis position B18 Set the z axis lower limit to the current z axis position B19 Clear z axis limits B20 Echo z axis limits

I have made some changes to Axis, GCode and Settings classes.

I would like to contribute it to the project.

Best Regards

ariasr commented 4 years ago

I have not been able to do a pull request. Perhaps I don't have the right permisions?

davidelang commented 4 years ago

you should be able to fork the repo and create a pull request from your fork.

David Lang

On Mon, 18 May 2020, ariasr wrote:

I have not been able to do a pull request. Perhaps I don't have the right permisions?

ariasr commented 4 years ago

Thank you. I finally figured it out and generated the pull request. Its already there for aproval.

Sent from my iPhone

On May 18, 2020, at 4:15 PM, David Lang notifications@github.com wrote:

 you should be able to fork the repo and create a pull request from your fork.

David Lang

On Mon, 18 May 2020, ariasr wrote:

I have not been able to do a pull request. Perhaps I don't have the right permisions?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

davidelang commented 4 years ago

be sure to give yoursef a thumbs up (on the robot's post)

David Lang On Mon, 18 May 2020, ariasr wrote:

Date: Mon, 18 May 2020 15:02:47 -0700 From: ariasr notifications@github.com Reply-To: MaslowCNC/Firmware reply@reply.github.com To: MaslowCNC/Firmware Firmware@noreply.github.com Cc: David Lang david@lang.hm, Comment comment@noreply.github.com Subject: Re: [MaslowCNC/Firmware] New Feature: Z Axis limits to prevent equipment strain (#542)

Thank you. I finally figured it out and generated the pull request. Its already there for aproval.

Sent from my iPhone

On May 18, 2020, at 4:15 PM, David Lang notifications@github.com wrote:

 you should be able to fork the repo and create a pull request from your fork.

David Lang

On Mon, 18 May 2020, ariasr wrote:

I have not been able to do a pull request. Perhaps I don't have the right permisions?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or unsubscribe.

-- You are receiving this because you commented. Reply to this email directly or view it on GitHub: https://github.com/MaslowCNC/Firmware/issues/542#issuecomment-630458020