MaslowCNC / GroundControl

This is the Ground Control software used to control the Maslow CNC Machine
https://www.MaslowCNC.com
GNU General Public License v3.0
275 stars 122 forks source link

Changing language in calibration process #785

Open guidobender opened 5 years ago

guidobender commented 5 years ago

Hi, I ran into some confusion when calibrating with the 1.26 ground control and triangular sled. I would like to suggest changing some of the wording to increase clarity. Please let me know if you have questions. Thanks Tschöhö Superbender

Current language of step to adjust chain length after motor-to-motor distance measurement:

Now we are going to adjust the chains to a known length.

If your chains are not attached place the first link of the chain on the vertical sprocket tooth. If your chains are already in place they may retract to the target length.

The correct length of first the left and then the right chain will be measured out. …(more text)

Text that I would suggest:

If your chains are already in place they may retract to the target length.

If your left chain is still attached to the right motor from the length measurement motor-to-motor, remove it from the right motor without changing the position it has on the left motor.

For chains that are not attached to a motor (typical calibration = right chain) place the first link of the chain on the vertical sprocket tooth.

…(more text)

BarbourSmith commented 5 years ago

That is an excellent idea. Thank you for giving me exact wording for what to change I will create a pull request to propose the change

BarbourSmith commented 5 years ago

I created #786 to add the change. Let me know what you think, and give it a 👍 once the robot comments if it looks good

GeroBH commented 5 years ago

To avoid the consitant confusion with bottom feed, replace the top feed bracket picture with the bottom feed triangular pic?

On Mon, 21 Jan 2019, 06:54 BarbourSmith <notifications@github.com wrote:

I created #786 https://github.com/MaslowCNC/GroundControl/pull/786 to add the change. Let me know what you think, and give it a 👍 once the robot comments if it looks good

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MaslowCNC/GroundControl/issues/785#issuecomment-455941018, or mute the thread https://github.com/notifications/unsubscribe-auth/AYnerC65ALXdM2-ugFiG2N0W9-Um4qqdks5vFTn-gaJpZM4aJ3D0 .

BarbourSmith commented 5 years ago

@GeroBH I agree. Having an updated picture is a good idea. Unfortunately I am not in a position to take one right away, but I will keep it on my todo list. Does anyone else have a good picture with the sled centered that we could use there?

guidobender commented 5 years ago

Below are a couple of images from my machine. I hope that helps. I have another suggestion regarding the calibration. Will open another issue shortly. Very cool to collaborate in this way. You guys rock.

img_4026 img_4025

GeroBH commented 5 years ago

merged commit c79e67d into master 13 days ago So can be closed?

BarbourSmith commented 5 years ago

I vote to close