search

MaslowCNC / GroundControl

This is the Ground Control software used to control the Maslow CNC Machine
https://www.MaslowCNC.com
GNU General Public License v3.0
277 stars 123 forks source link

Clean up serialPortThread() connection handshake #794

Closed blurfl closed 5 years ago

blurfl commented 5 years ago

• reset Arduino Mega by toggling DTR instead of open/close/open the port • send ctrl-X to trigger a soft reset for non-Arduino boards

Teensy3.5/3.6 and GrandCentralMetroM4 don't reset when GC does the special Arduino serial-port-reset trick. This adds a one-character command to trigger a soft reset. GRBL and MaslowDue use ctrl-X, so we match that.

There is a matching Firmware PR#513 to handle the ctrl-X.

MaslowCommunityGardenRobot commented 5 years ago

Congratulations on the pull request @blurfl

Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!

blurfl commented 5 years ago

@BarbourSmith , this PR seems to be stuck in the works - is the Robot on a holiday? 🤖🏝

BarbourSmith commented 5 years ago

I'm not sure what is going on there. The robot is merging other things...I wonder why it got stuck on this one. Thanks for pointing that out.