search

MaslowCNC / GroundControl

This is the Ground Control software used to control the Maslow CNC Machine
https://www.MaslowCNC.com
GNU General Public License v3.0
275 stars 122 forks source link

Pull Request to Merge Holey Calibration into MaslowCNC:main fork #798

Closed schmittjoshc closed 4 years ago

schmittjoshc commented 4 years ago

All changes from schmitjoshc/GroundControl:main being merged into MaslowCNC/GroundControl:main

blurfl commented 4 years ago

While this is a development that is much anticipated, maybe a PR that makes so many changes should wait until after the pending release. That would separate these changes from others and make testing and rollback easier.

MaslowCommunityGardenRobot commented 4 years ago

Congratulations on the pull request @schmittjoshc

Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!

blurfl commented 4 years ago

Closing this manually as the CommunityGarden robot for this repo seems to be on hiatus.

ted1735 commented 4 years ago

This looks amazing I want this.. Did it merge through

davidelang commented 4 years ago

no, we decided to hold off until after we make a release that includes all the other changes since January, then we will merge this for testing

David Lang

BarbourSmith commented 4 years ago

The people who are selling kits are testing the current release on their machines, if they say the release is OK then I will make a release and then we can reopen this pull request (which is awesome!)

Give it a 👍 vote and when it reopens it should merge automatically (although the robot needs some love soon)

davidelang commented 4 years ago

now that we have more than just you testing, can we set a schedule for testers? something like: take whatever is current at the 1st of the month and if nobody gives it a no vote by the 7th, it ships?

do this on odd-numbered months (which avoids Jan 1 and July 4 interrupting testing)?

I like a 'default ship' as that means that if someone drops out of testing or becomes unresponsive it can't block the release forever.

David Lang