add switch to disable FAKE_SERVO mode

MaslowCNC / GroundControl

This is the Ground Control software used to control the Maslow CNC Machine

https://www.MaslowCNC.com

GNU General Public License v3.0

277 stars 123 forks source link

add switch to disable FAKE_SERVO mode #804

Closed blurfl closed 5 years ago

blurfl commented 5 years ago

add a new switch that defaults to "Not allowed"
FAKE_SERVO hot key only works if switch set to "Allowed"
FAKE_SERVO can be turned off with hot key regardless of switch position

This PR addresses Firmware issue #531 "Does FAKE_SERVO need an alert when activating."

MaslowCommunityGardenRobot commented 5 years ago

Congratulations on the pull request @blurfl

Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.

I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!

MaslowCommunityGardenRobot commented 5 years ago

Time is up and we're ready to merge this pull request. Great work!