Closed schmittjoshc closed 4 years ago
Does this PR require that the matching firmware PR be already installed? I'm running the present MAslow v1.28GC crashed on the "Push to machine" step after running the holey calibration sequence:
Sending: G0 X0 Y355.6
Sending: G0 Z-5
Sending: G0 Z5
Sending: G0 X-965.2 Y355.6
Sending: G0 Z-5
Sending: G0 Z5
Sending: G0 X-965.2 Y-355.6
Sending: G0 Z-5
Sending: G0 Z5
Sending: G0 X0 Y-355.6
Sending: G0 Z-5
Sending: G0 Z5
Sending: G0 X965.2 Y-355.6
Sending: G0 Z-5
Sending: G0 Z5
Sending: G0 X965.2 Y355.6
Sending: G0 Z-5
Sending: G0 Z5
Sending: G0 X0 Y0
Sending: M5
Sending: $8=100.0000
[INFO ] [Base ] Leaving application in progress...
Traceback (most recent call last):
File "main.py", line 512, in <module>
GroundControlApp().run()
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/app.py", line 826, in run
runTouchApp()
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/base.py", line 502, in runTouchApp
EventLoop.window.mainloop()
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/core/window/window_sdl2.py", line 727, in mainloop
self._mainloop()
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/core/window/window_sdl2.py", line 460, in _mainloop
EventLoop.idle()
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/base.py", line 340, in idle
self.dispatch_input()
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/base.py", line 325, in dispatch_input
post_dispatch_input(*pop(0))
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/base.py", line 291, in post_dispatch_input
wid.dispatch('on_touch_up', me)
File "kivy/_event.pyx", line 707, in kivy._event.EventDispatcher.dispatch
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/uix/behaviors/button.py", line 179, in on_touch_up
self.dispatch('on_release')
File "kivy/_event.pyx", line 703, in kivy._event.EventDispatcher.dispatch
File "kivy/_event.pyx", line 1214, in kivy._event.EventObservers.dispatch
File "kivy/_event.pyx", line 1098, in kivy._event.EventObservers._dispatch
File "/Applications/Kivy.app/Contents/Resources/kivy/kivy/lang/builder.py", line 64, in custom_callback
exec(__kvlang__.co_value, idmap)
File "<string>", line 224, in <module>
File "/Users/myusername/Downloads/GroundControl-master-PR/CalibrationWidgets/holeyCalOptimize.py", line 228, in pushParamsToGC
v=self.Cal.__dict__[ehcnm]
KeyError: 'Opt_leftChainTolerance'
If this is true, this PR should be closed now and re-opened after the firmware PR is opened.
As posted in the forum, some work needed before this is ready to merge. Closing this to prevent premature merging. I suggest opening a new PR with the repaired version as the robot seems to work from the time the original PR was opened.
Congratulations on the pull request @schmittjoshc
Now we need to decide as a community if we want to integrate these changes. You should vote by giving this comment a thumbs up or a thumbs down. Votes are counted in 48 hours. Ties will not be merged.
I'm just a robot, but I love to see people contributing so I'm going vote thumbs up (but my vote won't count...)!