search

MasonProtter / ReplMaker.jl

Simple API for building repl modes in Julia
Other
134 stars 14 forks source link

Allow use at startup within `atreplinit` #30

Closed IlyaOrson closed 2 years ago

IlyaOrson commented 2 years ago

The README example to setup a mode with the startup file was not working for me. This suggestion seems to fix it in the README example, so I think it makes sense to do it by default.

MasonProtter commented 2 years ago

Thank you!

IlyaOrson commented 2 years ago

Not really sure why but this breaks the pkg> mode after the first use of the custom mode.

The previous version works fine with this modification to the README example:

atreplinit() do repl
    try
        @eval using REPL, ReplMaker
        repl.interface = REPL.setup_interface(repl)
        @async initrepl(
        ...

Should we revert this and just modify the README for the time being?

c42f commented 2 years ago

Yeah, this patch seems to break ReplMaker completely for me. Even the most basic example at the top of the README doesn't work for me anymore.