search

MasonProtter / ReplMaker.jl

Simple API for building repl modes in Julia
Other
134 stars 14 forks source link

Revert "Allow use at startup within `atreplinit`" #31

Closed c42f closed 2 years ago

c42f commented 2 years ago

30 seems to break ReplMaker completely for me. The first example in the readme doesn't work, for example.

So revert #30 for now and bump the version so we can have an emergency fix.

CC @IlyaOrson

MasonProtter commented 2 years ago

Good catch, sorry for the breakage. I tried this locally and it seems to work for me.

MasonProtter commented 2 years ago

We really need a better way to test repl modes with CI

pfitzseb commented 2 years ago

https://github.com/JuliaDebug/TerminalRegressionTests.jl to the rescue (although I'm not sure it would've caught this issue)!

MasonProtter commented 2 years ago

Oh, very cool! I'll have to try that out.

pfitzseb commented 2 years ago

Check out the Debugger.jl and Infiltrator.jl tests for usage examples.