search

MasonProtter / Symbolics.jl

A symbolic math library written in Julia modelled off scmutils
MIT License
107 stars 15 forks source link

Construct UpTuple/DownTuple as wrappers around Array instead of Tuple #12

Closed PerezHz closed 5 years ago

PerezHz commented 5 years ago

This PR is an attempt to fix #11. UpTuple and DownTuple are now wrappers around Vector (i.e., 1-dim Array), instead of Tuple, as is currently done. Tests seem to be passing, but I think it might be improved even more... is this kind of what you had in mind, @MasonProtter ?

PerezHz commented 5 years ago

Btw, I updated appveyor.yml, and this time I think the build was triggered correctly

MasonProtter commented 5 years ago

Looks good! Would you mind adding some more tests of the uptuples and downtuples?

PerezHz commented 5 years ago

Looks good! Would you mind adding some more tests of the uptuples and downtuples?

Great! Just added some more tests for UpTuple/DownTuple; I noted that DownTuple was not exported so added it to exports

PerezHz commented 5 years ago

This is where codecov would prove itself useful... Have you checked the codecov app has adequate permissions on your GitHub account? I was thinking that perhaps we could also try to use coveralls and see if we have better luck with that

MasonProtter commented 5 years ago

Yeah it has full permissions, no idea why this is happening. Perhaps coveralls is a good idea

PerezHz commented 5 years ago

Thanks for merging!