search

MasoniteFramework / interfaces

Python Interface Implementation
3 stars 1 forks source link

Add "I" and "Contract" to the lookup #1

Closed josephmancuso closed 5 years ago

josephmancuso commented 5 years ago

currently contracts are identified when they end with Interface like AuthenticationInterface but they should also be identified when they end with Contract like AuthenticationContract or start with the letter I like IAuthentication.

The I part may get tricky because it will conflict with things like a base class of Igloo so maybe we can do another check somehow with that one.

Marlysson commented 5 years ago

Where do we find the Igloo class that could be conflicting?

josephmancuso commented 5 years ago

Yeah it’s gonna be a problem. The only reason to put the I in front is when you come from languages like Java where all interfaces have an I in front

Marlysson commented 5 years ago

But inherit from Interface base class isn't enough to handle it as the interface?

josephmancuso commented 5 years ago

don't think this is possible