MasoniteFramework / masonite4

Temporary Repository for a Masonite Rewrite for Masonite 4
14 stars 3 forks source link

Add Mail Support #10

Closed josephmancuso closed 3 years ago

josephmancuso commented 3 years ago

This is one of the features we will need to rethink. We need to structure the classes differently I think and add better support for things like Mailables and other type classes

girardinsamuel commented 3 years ago

Totally agree !

girardinsamuel commented 3 years ago

As for the drivers, actual ones are great, if some people want to add new ones well they can open a PR. And maybe with time some drivers will be added through external packages ?

josephmancuso commented 3 years ago

@Marlysson @girardinsamuel So far i built Masonite to be extremely adaptable and modular. Each feature from now on will be completely isolated from Masonite and then just registered in.

With that being said, we need to start thinking of how this feature will work. This is one of those features that I built very early on with Masonite. Probably one of the first 3 features. Because of that, we can't port that over I don't think and I would rather write it from scratch

josephmancuso commented 3 years ago

We need to support:

josephmancuso commented 3 years ago

This is going to have to be something I do as I have a few ideas on how we can achieve this ..

girardinsamuel commented 3 years ago

Totally agree with the list of features to support. Let me know if you need help or want to discuss some parts. I would maybe add to the list (even if not directly related), a way to test the mail service properly, as I discussed in #13 .

Maybe that's the parts I could help you on: testing assertions for different features of the framework

josephmancuso commented 3 years ago

@girardinsamuel That's actually a great idea I'll open an issue