search

MasoniteFramework / orm

Masonite ORM is a beautiful Python ORM. It's also a nearly drop in replacement of the Orator ORM
https://orm.masoniteproject.com
MIT License
160 stars 47 forks source link

Fixed #848 #849

Closed botify-framework closed 7 months ago

tpow commented 1 year ago

As I wrote in my comment in #843, I feel like the problem is "caused by the Model.save adding the id_key when it calls create. This means Model.create gets the id_key in the kwargs, but then adds it again. Arguably, save doesn't need to add it." Are there any use-cases where passing the id_key to create is valuable? Is this necessary in first_or_create?

josephmancuso commented 7 months ago

this was fixed in https://github.com/MasoniteFramework/orm/pull/856