Closed matt2930 closed 7 months ago
Describe the feature as you'd like to see it I want to be able to specify a custom config path without setting an extra environment variable.
What do we currently have to do now? The current implementation of ConnectionResolver and ConnectionFactory does the following:
ConnectionResolver
ConnectionFactory
make
DB = load_config().DB
load_config()
DB_CONFIG_PATH
Additional context The load_config function already has a config_path argument. So, my proposal is to:
config_path
Add an optional config_path argument to ConnectionResolver
Add an optional config_path argument to ConnectionFactory
Pass through that config_path from ConnectionResolver to the initialization of ConnectionFactory
Use the config_path in load_config
load_config
[ ] Is this a breaking change?
Describe the feature as you'd like to see it I want to be able to specify a custom config path without setting an extra environment variable.
What do we currently have to do now? The current implementation of
ConnectionResolver
andConnectionFactory
does the following:ConnectionResolver
initsConnectionFactory
ConnectionFactory
will runmake
, which callsDB = load_config().DB
load_config()
will either use the default config path, or use theDB_CONFIG_PATH
env varAdditional context The load_config function already has a
config_path
argument. So, my proposal is to:Add an optional
config_path
argument toConnectionResolver
Add an optional
config_path
argument toConnectionFactory
Pass through that
config_path
fromConnectionResolver
to the initialization ofConnectionFactory
Use the
config_path
inload_config
[ ] Is this a breaking change?