search

MasoniteFramework / orm

Masonite ORM is a beautiful Python ORM. It's also a nearly drop in replacement of the Orator ORM
https://orm.masoniteproject.com
MIT License
160 stars 47 forks source link

Update to Pendulum 3 #876

Open felipehertzer opened 4 months ago

felipehertzer commented 4 months ago

Describe the bug I'm trying to use the package with Python 3.12 but the pendulum dependencie doesn't allow it. Is there any reason why it is locked at pendulum>=2.1,<2.2? I think it could be updated without any major change.

To Reproduce Steps to reproduce the behavior:

  1. Use Python 3.12
  2. pip install masonite-orm
  3. See error

Expected behavior Be able to use Masonite with Python 3.12

Desktop (please complete the following information):

Additional context Any other steps you are doing or any other related information that will help us debug the problem please put here.

josephmancuso commented 3 months ago

Pendulum 3 i believe is a breaking change. so to fix this ill need to fix this and then upgrade the package to from version 2.x to version 3.x.

although this needs to be solved its not as simple as just bumping the pendulum version