MasoniteFramework / orm

Masonite ORM is a beautiful Python ORM. It's also a nearly drop in replacement of the Orator ORM
https://orm.masoniteproject.com
MIT License
160 stars 47 forks source link

Add some type-hints to Model.py #881

Closed JarriqTheTechie closed 4 weeks ago

JarriqTheTechie commented 3 months ago

When adding multiple return types I will use Union instead of pipe operator.

josephmancuso commented 3 months ago

also tests are failing

JarriqTheTechie commented 3 months ago

also tests are failing

Tests are failing due to issues with backwards compatibility with older versions of python. That's why I'll use Union types instead of | as a type separator.

josephmancuso commented 1 month ago

please fix tests failing. i'd like to merge this in

josephmancuso commented 4 weeks ago

closing bc of tests failing