search

MasoniteFramework / orm

Masonite ORM is a beautiful Python ORM. It's also a nearly drop in replacement of the Orator ORM
https://orm.masoniteproject.com
MIT License
160 stars 47 forks source link

fix: values in compile_alter_sql #885

Open Kyrela opened 2 weeks ago

Kyrela commented 2 weeks ago

fix #884

note that the change line 343 doesn't change anything as the function isn't used, but could be useful if this behavior is changed.

Works with the example given in the issue.

Kyrela commented 2 weeks ago

Should I edit BaseConnection.py to remove the additional blank line?

josephmancuso commented 2 weeks ago

Should I edit BaseConnection.py to remove the additional blank line?

idk what youre talking about but sure i think

Kyrela commented 2 weeks ago

I'm talking about the lint results. image No link with my PR, but as the linter is triggered by it, I guess I could fix it?

josephmancuso commented 2 weeks ago

oh, yes please

josephmancuso commented 2 weeks ago

adding tests are pretty simple if you could add one for enum

Kyrela commented 2 weeks ago

adding tests are pretty simple if you could add one for enum

Oh, sure, was thinking about it.

Kyrela commented 2 weeks ago

Not sure about the quality of my tests tbh, but I added a test for the bug referenced in issue #885 and tests for changing an enum or adding it in a new table. If these are good, should I add similar ones for the other sql dialects?

josephmancuso commented 2 weeks ago

Not sure about the quality of my tests tbh, but I added a test for the bug referenced in issue #885 and tests for changing an enum or adding it in a new table. If these are good, should I add similar ones for the other sql dialects?

yes please, code looks good 👍

Kyrela commented 9 hours ago

Hello, any update?