MasoudSeraji / final_project_Matlab_2018

0 stars 0 forks source link

Initial Review #1

Closed bartkrekelberg closed 5 years ago

bartkrekelberg commented 5 years ago

My main criticism is that the code in the main script is not generic enough - it runs ok for the current choices, but if you want to run a different subject or change even one analysis setting you have to dig through the whole file to make sure everything is changed accordingly. That is not a good practice.

You make all kinds of assumptions about which subjects to run, which channels to plot etc. and put all these as bare numbers in your code. That is not a good style.

Also there is a lot of code duplication - you want to do the identical analysis for parvo/magno/konio.

The same is true for the graphcial output: duplicated code, and parameters that are hard-coded.

Is this figure really something you would submit to JNeurosci?

bartkrekelberg commented 5 years ago

Big improvement!

By the way, try Ctrl-A, Ctrl-I to improve the formatting