Masquerade-Circus / mongoose-history-plugin

Mongoose plugin that saves history in JsonPatch format and SemVer format.
Apache License 2.0
48 stars 25 forks source link

Separate mongoose and connection in options param #29

Open antonio-spinelli opened 4 years ago

antonio-spinelli commented 4 years ago

I found a problem installing plugin to a Schema when I use it with NestJs/Mongoose. The only instance that I can access is the Connection mongoose class and it's not fully compatible with the mongoose option needed by the plugin. I use an ugly way to solve this in my project:

constructor(@InjectConnection() private readonly connection: Connection) {}

...

;(this.connection as any).Schema = mongoose.Schema
schema.plugin(MongooseHistoryPlugin({mongoose: this.connection}))

Can you split those 2 in options or use require mongoose for static Schema calls and ask only for connection instance? Both options will not generate breaking changes. I can make a PR if you want.

PS: a typescript interface with all new document methods will be cool

cdunlap commented 2 years ago

Year and a half later, this helped me. Thank you. I think this project is dead though, considering 2 years of no updates and 12 PR's that haven't been merged.