search

MassBank / MassBank-data

Official repository of open data MassBank records
68 stars 55 forks source link

381 GC-APCI-QTOF records for MassBank #168

Closed nalygizakis closed 3 years ago

nalygizakis commented 3 years ago

Hi MassBank consortium,

I processed some GC-APCI-QTOF files and created few MassBank records, which I would like to share with you.

Kind regards, Nikiforos

tsufz commented 3 years ago

Dear Nikiforos, Thanks a lot for your submission! However, the records need refinement. They contain a tag AC$ANALYTICAL_CONDITION. This tag is not a valid MassBank tag. Please find the record format at https://github.com/MassBank/MassBank-web/blob/main/Documentation/MassBankRecordFormat.md.

You can keep the pull request open. Just update the records and push them again to your forked repository. GitHub will then take care of it.

Best wishes, Tobias

meier-rene commented 3 years ago

Hi Nikiforos, we received many valuable contribution from you. Thats why I know that you can create correct massbank records. But this time something went wrong in your creation process. We dont have a keyword AC$ANALYTICAL_CONDITION. Its AC$MASS_SPECTROMETRY and AC$CHROMATOGRAPHY in your case. Please check our documentation as Tobias wrote and fix your creation pipeline. I was able to fix it for you. Best, Rene

meowcat commented 2 years ago

If you are using RMassBank, this should be as easy as setting the record version to 2 in the settings :)