search

MassBank / MassBank-data

Official repository of open data MassBank records
77 stars 60 forks source link

Missing or mismatching MassBank directories #2

Closed schymane closed 6 years ago

schymane commented 6 years ago

I'm trying to reconcile what I see on massbank.eu and massbank.jp with the directories in this repo, the following seem to be missing (num. records MBEU / num. records MBJP) AAFC (292/0) CASMI2016 (622/622) Env Anal Chem, U Tuebingen (119/119) European MassBank (1/0) <= not a major concern as this is a dummy entry UPAO (12/12)

The following are present in this repo but not online: CASMI_2012

The following folders are in the OpenData here: http://www.massbank.jp/SVN/OpenData/record/ CASMI_2016, Env_Anal_Chem_U_Tuebingen, UPAO

I cannot see AAFC there.

schymane commented 6 years ago

Adding CASMI 2016: https://github.com/meier-rene/MassBank-data/pull/4/commits/db750f970d24bbf649db4dcca60d47995e78d22d

schymane commented 6 years ago

Adding Env_Anal_Chem_U_Tuebingen https://github.com/meier-rene/MassBank-data/pull/4/commits/0d123c032eec2cb32c53389d4ab255b3ad97a433

schymane commented 6 years ago

...and adding UPAO: https://github.com/meier-rene/MassBank-data/pull/4/commits/af293f2bc9344df908e3eec47393ab17ea1691a2

sneumann commented 6 years ago

I have added a PR to include AAFC into validation https://github.com/meier-rene/MassBank-data/pull/5 The directories CASMI_2016, Env_Anal_Chem_U_Tuebingen, UPAO were already in the validation, but indeed not yet in the record data. Yours, Steffen

meier-rene commented 6 years ago

Thanks for checking this. Unfortunately we have some overlap here. I was not fast enough to push all records to the remote repo. In my local repo I have already: CASMI2016 622 records Env_Anal_Chem_U_Tuebingen 199 records UPAO 12 records. But they are not pushed yet, because of validation errors.

The AAFC is not included, because up to now I have not downloaded any files from MBEU. I have just fetched the MBJP repo. If there are any files which are only hosted at MBEU, they will be missing atm. I will go through this with @tsufz.

tsufz commented 6 years ago

I would appreciate if all massbank.eu hosted records are fetched from massbank.eu and not from massbank.jp in order to avoid mismatches. Please replace them. The open access records can be downloaded from https://massbank.eu/MassBank/SVN/OpenData/ using wget or curl.

tsufz commented 6 years ago

Today, the library of Nihon was updated. Please fetch from massbank.eu

meier-rene commented 6 years ago

All records have been updated with the most recent version.