search

MassBank / MassBank-data

Official repository of open data MassBank records
68 stars 55 forks source link

US EPA API is back #214

Closed tsufz closed 1 year ago

tsufz commented 1 year ago

Hi all, the US EPA API is back. See https://api-ccte.epa.gov/docs/chemical.html. However, an APIkey is required to retrieve the data. Hence, we need to decide, if people should use their own APIkey (to be implemented also in RMassBank) or if we automatically infuse US EPA data (e.g. DTXSID) in the records during submission?

sneumann commented 1 year ago

Hi, I recommend to close the issue here and move to MassBank-web or rather RMassBank. Currently, MassBank-web does no data manipulation upon import. Yours, Steffen

schymane commented 1 year ago

Not sure why it would belong more on MassBank-web than in MassBank-data - as this is something that would enhance data records and could be screened / added as part of validation (similar to e.g. adding missing InChIKeys if SMILES and InChI are available). Having it here (MassBank-data) is a more central solution than RMassBank, as we are getting increasing contributions via their own workflows and not just RMassBank?

tsufz commented 1 year ago

Yes, @sneumann is right. This is a validator issue. I am always a friend of central, automated services rather than extra work in RMassBank.

tsufz commented 1 year ago

Discussion moved to https://github.com/MassBank/MassBank-web/issues/372.