MassBank / MassBank-data

Official repository of open data MassBank records
74 stars 59 forks source link

Add Shin-MassBank record #257

Closed RyosukeHayasaka closed 5 months ago

meier-rene commented 5 months ago

Welcome to MassBank and thank you for your contribution.

I had a look at your records and there is a small number of issues.

  1. The title in MassBank has a fixed format and a; is the field separator of that format. We can not have Measured; in the title. If you want to put additional information in your record file please use the COMMENT field. I realized you already put a lot of additional information there. We appreciate that.
  2. Please make sure that the compound described in the SMILES field and in the InChI field are exactly the same. If you choose to specify stereochemical information in the InChI this is also necessary in the SMILES. If you look up information about your compound in pubchem I recommend to use the Isomeric SMILES field.
  3. Please do not use additional space characters in your PK$ANNOTATION table, because that breaks our validation. If its possible to modify your pipeline to create that table without additional spaces I would appreciate it.

I did all the small modifications I mentioned above and merged the PR. We looking forward to future contributions.