MassBank / MassBank-data

Official repository of open data MassBank records
77 stars 60 forks source link

UFZ additional specs validation: Incorrect number of peaks in peaklist #8

Closed sneumann closed 6 years ago

sneumann commented 6 years ago

Hi, currently the last directory failing is https://travis-ci.org/MassBank/MassBank-data/jobs/368060988

Incorrect number of peaks in peaklist. 16 peaks are declared in PK$NUM_PEAK line, but 13 peaks are found.
PK$PEAK: m/z int. rel.int.
^
Error in UA008702.txt
Incorrect number of peaks in peaklist. 13 peaks are declared in PK$NUM_PEAK line, but 11 peaks are found.
PK$PEAK: m/z int. rel.int.
^
Error in UA008703.txt
Incorrect number of peaks in peaklist. 8 peaks are declared in PK$NUM_PEAK line, but 7 peaks are found.
PK$PEAK: m/z int. rel.int.
^
Error in UA008704.txt

for e.g. https://github.com/MassBank/MassBank-data/blob/master/UFZ_Additional_Specs/UA008704.txt

Yours, Steffen

schymane commented 6 years ago

Strange … this makes no sense as the MassBank upload picks this up and will not allow import if they mismatch. Please fix the number of peaks, these records must have been manually adjusted following RMassBank (@tsufz please confirm … either that or we have a bug?). Looking at the records @tsufz maybe uploaded these directly and not via the mbadmin page?

MS$DATA_PROCESSING: WHOLE RMassBank 2.5.0

meier-rene commented 6 years ago

I fixed it by adjusting PK$NUM_PEAK to the number of peaks which are actually in the record.

sneumann commented 6 years ago

Cool, all green now !