search

MassBank / MassBank-web

The web server application and directly connected components for a MassBank web server
14 stars 22 forks source link

Update record format #204

Closed tsufz closed 4 years ago

tsufz commented 4 years ago

Revision of Record Format and Bump to version 2.4

tsufz commented 4 years ago

@meier-rene and @sneumann. Why is the new records not yet merged to the master? Do we need some implementations?

meier-rene commented 4 years ago

Hi @tsufz, I haven't merged this PR because it touches far more files than MassBankRecordFormat.md and I didn't took time to investigate whats going on here. Looks like a accidentally copy and paste of the whole Project source to the compose folder. To get this in fast, please answer the following two questions:

  1. Should this PR update only the MassBankRecordFormat.md-file?
  2. Are the commit messages important to you or can I just merge the content of `MassBankRecordFormat.md from my account?
tsufz commented 4 years ago

@meier-rene , it touches only the record format. I think there was line feed problem. The rest happened accidently....

tsufz commented 4 years ago

sorr for the unconviences...

meier-rene commented 4 years ago

Thank you for updating the record format. I have merged your changes to MassBankRecordFormat.md manually from your fork and committed with 6208e9a01560c28223cf981d45fd20216bd33fcb, thus closing your PR. Because your tsufz/MassBank-web:update_record_format branch has a broken codebase I suggest you delete it.