search

MassBank / MassBank-web

The web server application and directly connected components for a MassBank web server
13 stars 22 forks source link

Add link to external visualisation tool #218

Closed sneumann closed 4 years ago

sneumann commented 4 years ago

Prototype for Link out to external Visualisation via the https://metabolomics-usi.ucsd.edu/ Closes https://github.com/mwang87/MetabolomicsSpectrumResolver/issues/62 Improvements could be a nicer element (Link out icon ?) Currently an example is e.g. https://msbi.ipb-halle.de/MassBank/RecordDisplay.jsp?id=UA002901 Yours, Steffen

berlinguyinca commented 4 years ago

how is this different to the splash, what is the need for this?

On Tue, Jan 28, 2020 at 9:56 PM Steffen Neumann notifications@github.com wrote:

Prototype for Link out to external Visualisation via the https://metabolomics-usi.ucsd.edu/ Closes mwang87/MetabolomicsSpectrumResolver#62 https://github.com/mwang87/MetabolomicsSpectrumResolver/issues/62 Improvements could be a nicer element (Link out icon ?) Currently an example is e.g. https://msbi.ipb-halle.de/MassBank/RecordDisplay.jsp?id=UA002901 Yours, Steffen

You can view, comment on, or merge this pull request online at:

https://github.com/MassBank/MassBank-web/pull/218 Commit Summary

  • Add link to external visualisation tool

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/MassBank/MassBank-web/pull/218?email_source=notifications&email_token=AAAD73DU6F2G5FL43NN6NPTRACSZPA5CNFSM4KM2I7HKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IJLN6PQ, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAD73AM4A4HMRZ4TYL2XU3RACSZPANCNFSM4KM2I7HA .

--

Lead Software Developer - Fiehnlab, UC Davis

gert wohlgemuth

work: http://fiehnlab.ucdavis.edu/staff/wohlgemuth

phone: 530 665 9477, email preferred!

linkedin: https://www.linkedin.com/in/berlinguyinca http://www.linkedin.com/profile/view?id=28611299&trk=tab_pro

sneumann commented 4 years ago

Hi Gerd, the external visualisation is in my opinion independent of the SPLASH. The embedded MassBank viewer is JavaScript and can't be put into a manuscript (or supplemental information), the MetabolomicsSpectrumResolver can produce a configurable PNG with options (label rotation ...) I'd never want to implement in MassBabk-web, hence the link-out. Hope that helped, yours, Steffen