MassBank / MassBank-web

The web server application and directly connected components for a MassBank web server
14 stars 22 forks source link

Peak search by absolute intensities #245

Open tsufz opened 4 years ago

tsufz commented 4 years ago

During the Virtual Podium I was asked if we could add absolute intensity search to MassBank? I dunno if this makes sense, but should be no big issue.

sneumann commented 4 years ago

I would need to be convinced, the absolute intensity depends on instrument, sample concentration etc. Yours, Steffen

schymane commented 4 years ago

Well ... maybe people could input absolute intensity but we would have to relativize it and search on that (which would mean the underlying search would be the same as already exists)? Is the current search dependent on input of relative intensity only?

tsufz commented 4 years ago

Hmm, but we need the absolute intensity of the base peak to recalculate to absolute values. I guess, the search algorithm could be the same with some extension. Relative intensity search is the status. I am also not conviced about the absolute intensites. If they would be stable and independent from sample conditions (they are not as @sneumann said), we would have less problems with similarity search at all. I suggest to keep the status, recalculation to relative values is no magic.

schymane commented 4 years ago

Well - if people input absolute intensities, calculating relative intensities is trivial too, based on max(I) of the provided list. There's little point searching on absolute intensities, but one could provide a service to accept absolute intensities, but search relative behind the scenes, this is what any algorithm does anyway

tsufz commented 4 years ago

Okay, but this needs some adjustment in the pipeline after peaklist import. I think it is doable and we should think from the service view, not from the freak view.