search

MassBank / MassBank-web

The web server application and directly connected components for a MassBank web server
14 stars 22 forks source link

JSON-LD: incorrect capitalisation of InChIKey property #318

Open sneumann opened 2 years ago

sneumann commented 2 years ago

Hi, another report came in from @AlasdairGray (keep it flowing !)

We’ve found that you have not used the correct character sequence for the InChIKey property. Your markup has inchikey while the Schema.org property is inChIKey. Strangely the Schema.org validator does not create an error message for this. I’ve raised this with Dan Brickley to get his thoughts, but it will certainly raise problems for people trying to consume your markup.

This would be in https://github.com/MassBank/MassBank-web/blob/12f119605ac63d1574bffa4b670a46ce9b9ab564/MassBank-Project/MassBank-lib/src/main/java/massbank/Record.java#L678

We're currently moving to create the JSON via a proper JSON library to also handle #316, so the fix should directly go into that.

Yours, Steffen