MassBank / MassBank-web

The web server application and directly connected components for a MassBank web server
13 stars 22 forks source link

Update RecordDisplay.jsp #392

Closed Adafede closed 10 months ago

Adafede commented 10 months ago

Removing unneeded part of the usi.

Additional comment: It seems that underscores _ break the visualization using https://metabolomics-usi.gnps2.org/. (see https://massbank.eu/MassBank/RecordDisplay?id=MSBNK-BGC_Munich-RP000611 or https://massbank.eu/MassBank/RecordDisplay?id=MSBNK-Keio_Univ-KO001261 in comparison to https://massbank.eu/MassBank/RecordDisplay?id=MSBNK-RIKEN-PR100496 (no underscore).

Also tagging @mwang87

sneumann commented 10 months ago

Hi, indeed, there was the leftover fixed (and hence wrong) accession in the USI. The patch will change https://metabolomics-usi.gnps2.org/spectrum/?usi=mzspec:MASSBANK::accession:MSBNK-AAFC-AC000372/spectrum/?usi=mzspec:MASSBANK::accession:MSBNK-RIKEN-PR100496 to https://metabolomics-usi.gnps2.org/spectrum/?usi=mzspec:MASSBANK::accession:MSBNK-RIKEN-PR100496

I don't understand yet why underscores break the visualisation.

Both MSBNK-Keio_Univ-KO001261 and MSBNK-RIKEN-PR100496 are valid regarding the regex MSBNK-[A-Za-z0–9_]{1,32}-[A-Z0–9_]{1,64} in https://github.com/MassBank/MassBank-web/blob/dev/Documentation/MassBankRecordFormat.md#211-accession. The record namespace Keio_Univ has the allowed underscore.

Question: is there a regex for the USI, where that underscore separates something ? If yes, one would need some kind of quoting \_ or %5F or whatever on both sides.

Yours, Steffen

mwang87 commented 10 months ago

Thanks @sneumann and @Adafede. Glad its resolved, but I am also confused why it failed because we are using the same regex you listed @sneumann. Well it works now!

Adafede commented 10 months ago

Hey @mwang87! I actually probably saw the underscore regexp pattern while the issue rather was that the spectra contain only 1 peak if you remove the very small ones, reason why they do not show! Link is fixed but those spectra still not displayed…

mwang87 commented 10 months ago

Do you have a quick example USI where it doesn't visualize?

Adafede commented 10 months ago

Sure: https://metabolomics-usi.gnps2.org/dashinterface/?usi=mzspec%3AMASSBANK%3A%3Aaccession%3AMSBNK-Keio_Univ-KO001261

mwang87 commented 10 months ago

Thanks! Will take a look after the Metabolomics School is over this week.

On Tue, Aug 22, 2023 at 11:14 AM Adriano Rutz @.***> wrote:

Sure: https://metabolomics-usi.gnps2.org/dashinterface/?usi=mzspec%3AMASSBANK%3A%3Aaccession%3AMSBNK-Keio_Univ-KO001261

— Reply to this email directly, view it on GitHub https://github.com/MassBank/MassBank-web/pull/392#issuecomment-1688687986, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAXSEBC2HKTDLRWCTP74STXWTZINANCNFSM6AAAAAA3ZOE2XY . You are receiving this because you were mentioned.Message ID: @.***>