Docker compose version is not estimated correctly in `install.sh`

MassBank / MassBank-web

The web server application and directly connected components for a MassBank web server

13 stars 22 forks source link

Docker compose version is not estimated correctly in `install.sh` #395

Closed tsufz closed 9 months ago

tsufz commented 10 months ago

$ bash ./install.sh start 2`
Docker Compose V2 version 2.20.2 found. Using command 'docker compose'.

$ docker-compose -v
docker-compose version 1.xx

docker compose has version 1.xx, so the query is not working correctly.

meier-rene commented 10 months ago

You are right. I already realized this issue and I tried to fix it in dev. I will make some more testing and if everything is fine I will hotfix this in the release.

tsufz commented 10 months ago

Okay, was maybe a local problem due to some fixes of the local install.sh, but I wait for your tests before I release new server.

meowcat commented 9 months ago

Docker compose v1 (docker-compose) may be present in addition to Docker compose v2 (docker compose). So I don't think this is necessarily a bug.

meier-rene commented 9 months ago

All is good now I think. I have made some small modifications two weeks ago and tested all combinations I'm aware of. Tobias also resolved his issue. This can be closed.