MassGIS / morisoliver

Automatically exported from code.google.com/p/morisoliver
2 stars 2 forks source link

Problem re-adding tilesets #195

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
If I have a tileset such as Structures drawing then  switch to "Create custom 
basemap" that tileset is removed from "Active Data Layers" which is OK.  But 
then I can't add them Structures back after I switch back to "MassGIS Statewide 
Basemap" -- (I can add other tilesets which I didn't have before).  It's like 
OLIVER thinks it's already there.

Original issue reported on code.google.com by Aleda.Fr...@state.ma.us on 3 Jan 2013 at 8:46

GoogleCodeExporter commented 9 years ago
r415

Original comment by cpl...@gmail.com on 4 Jan 2013 at 8:09

GoogleCodeExporter commented 9 years ago
Well... 1) Switching to custom basemap throws away the non-tileset layers too.  
Shouldn't they stay?  When we use layergroups "MassGIS Default Map" where in 
the folderset only_project="EPSG:26986" which means it's only applicable to the 
custom basemap, if we switch to another basemap it stays with a yellow "!" and 
is unchecked.  When we switch back to custom it stays unchecked (user has to 
check it back on).  All the point/line/poly/raster layers are OK on top of any 
basemap.  It would be good if the tilesets worked the same way - if user 
switches to custom, they go yellow "!" and unchecked until user switches to any 
other basemap.  Point/line/poly/raster layers should stick around and work on 
any basemap. 

Original comment by Aleda.Fr...@state.ma.us on 4 Jan 2013 at 9:05

GoogleCodeExporter commented 9 years ago
Please give r421 a shot.

Original comment by cpl...@gmail.com on 5 Jan 2013 at 3:25

GoogleCodeExporter commented 9 years ago
When I switch to custom the tileset layers stay in the datalayer now with 
yellow "!" icon which is good. And when I switch back to the "MassGIS Statewide 
Basemap" then stay and even get checked back on which is great! 

Related to the red "!" comment in Issue 193.  When I switch to Custom basemap I 
see the red "!" icon briefly before it settles on the appropriate yellow "!" 
now.  It's as if the intermediate default icon that passes through in some 
state changes is the red "!" once instead of the neutral tile.png with no "!". 

Original comment by Aleda.Fr...@state.ma.us on 7 Jan 2013 at 2:42

GoogleCodeExporter commented 9 years ago
Please try r423.

Original comment by cpl...@gmail.com on 7 Jan 2013 at 4:47

GoogleCodeExporter commented 9 years ago
The red "!" issue is gone, but there is another small issue.

When I switch from "MassGIS Statewide Basemap" to "Create custom basemap" all 3 
tilesets should go to yellow "!" but they don't always depending on the zoom.  
They should be yellow "!" on  "Create custom basemap" since that is a 
non-standard tile system.  

If I'm zoomed in and everything is drawn the 3 yellow "!" do appear when I 
switch to 
"Create custom basemap".  
http://maps.massgis.state.ma.us/map_ol_tile/oliver.php?lyrs=Structures~Basemaps_
Structures~|Tax%20Parcels~Basemaps_L3Parcels~|Detailed%20Features~Basemaps_MassG
ISBasemapWithLabels1~|Pre-kindergarten%20to%20High%20School%20Buildings~massgis:
GISDATA.SCHOOLS_PT~GISDATA.SCHOOLS_PT::Default&bbox=-69.97760525488677,41.839503
80758226,-69.96894171977061,41.843084641903154&coordUnit=m&measureUnit=m&base=Ma
ssGIS_Basemap¢er=-7789389.1737479,5137235.6589658&zoom=18&opacity=1,1,1,1&baseO
=1&filt=undefined|undefined|undefined|undefined

However, at the beginning of the viewer, when 2 of the 3 tilesets have yellow 
"!" due to scale restrictions, changing to "Create custom basemap" should cause 
"Detailed Features" to do yellow "!" and it doesn't. 

http://maps.massgis.state.ma.us/map_ol_tile/oliver.php?lyrs=Structures~Basemaps_
Structures~|Tax%20Parcels~Basemaps_L3Parcels~|Detailed%20Features~Basemaps_MassG
ISBasemapWithLabels1~|Parcels%20Level%203%20No%20Roads%20for%20Query~massgis:GIS
DATA.L3_TAXPAR_POLY_ASSESS~Blank_Polys_Max_17100|NavTeq%20MA%20Other%20Streets%2
0for%20Query~massgis:GISDATA.NAVTEQRDS_ARC~Blank_Lines_Max_50000|Pre-kindergarte
n%20to%20High%20School%20Buildings~massgis:GISDATA.SCHOOLS_PT~GISDATA.SCHOOLS_PT
::Default&bbox=-73.977279083222,41.11421687267149,-69.41105535036313,42.98138534
5522185&coordUnit=m&measureUnit=m&base=custom¢er=184155.10130558,868852.9974743
8&zoom=2.589430769757945&opacity=1,1,1,1,1,1&baseO=1&filt=undefined|undefined|un
defined|undefined|undefined|undefined

Original comment by Aleda.Fr...@state.ma.us on 7 Jan 2013 at 5:04

GoogleCodeExporter commented 9 years ago
Could you verify that for these tilesets, you are passing me an only_project 
attr?  For whatever reason, I don't see any in my OL_MORIS_cache.  It's been a 
while, so I  might be looking in the wrong place.

Original comment by cpl...@gmail.com on 7 Jan 2013 at 5:33

GoogleCodeExporter commented 9 years ago
I wasn't, do you want me too?  Doesn't "only_project" mean, this layer is valid 
only in 26986 custom basemap.  Whereas the tilesets are the other way around - 
not valid in 26986 custom basemap (because it's not based on Google style 
tiles).

Original comment by Aleda.Fr...@state.ma.us on 7 Jan 2013 at 7:41

GoogleCodeExporter commented 9 years ago
Oh, hmm.  Then we may have a problem.  We don't have a way to identify a list 
of supported projections for a particular layer do we?  I think we only have 
that type of thing available for externalGetCaps.

Without this, we can't show any kind of proj warning.

Original comment by cpl...@gmail.com on 7 Jan 2013 at 7:53

GoogleCodeExporter commented 9 years ago
But we know a tileset is a tileset by type="tiled_overlay" in the folderset 
XML. Tileset layers are OK for all the Google-type basemaps but not for the 
Create custom 26986.  

Original comment by Aleda.Fr...@state.ma.us on 7 Jan 2013 at 7:55

GoogleCodeExporter commented 9 years ago
If you say that I can assume this, then I can work w/ that.  But this will 
break once you have tilesets available for 26986.

Original comment by cpl...@gmail.com on 7 Jan 2013 at 7:57

GoogleCodeExporter commented 9 years ago
r425

Original comment by cpl...@gmail.com on 7 Jan 2013 at 8:00

GoogleCodeExporter commented 9 years ago
Hmm.  We might make tilesets for 26986 eventually, but I'm not sure. 
I suppose it would be smarter to have a way to identify a list of supported 
projections.  Currently GeoServer layergroups are "26986".  Tilesets are 
"900913" I suppose. The lists are never going to be very long.  We could add an 
optional attribute to the folderset.  If it's not there, the layer is a 
vector/raster that can be reprojected to anything.  If it's valid_proj="26986" 
or valid_proj="900913" for example, then it would be valid for the list 
vaild_proj="A,B,C" sort of thing.  That would then make only_project redundant 
I think. 

Original comment by Aleda.Fr...@state.ma.us on 7 Jan 2013 at 8:01

GoogleCodeExporter commented 9 years ago
That sounds like a good approach, but it also sounds like a new issue.  If 
you're OK w/ the r425 change, it should work for the current setup.

Original comment by cpl...@gmail.com on 7 Jan 2013 at 8:04

GoogleCodeExporter commented 9 years ago
Agree, I'll make a new Issue as an enhancement to keep the idea and mark it low 
priority for now. 

Original comment by Aleda.Fr...@state.ma.us on 7 Jan 2013 at 8:05

GoogleCodeExporter commented 9 years ago
The yellow "!" appear for tilesets when I switch to custom basemap now - good.

Original comment by Aleda.Fr...@state.ma.us on 7 Jan 2013 at 8:20

GoogleCodeExporter commented 9 years ago
For some reason the tilesets are not drawing now on top of basemaps such as 
Bing.... 

For example this draws on MassGIS basemap:

http://maps.massgis.state.ma.us/map_ol_tile/oliver.php?lyrs=Structures~Basemaps_
Structures~|Tax%20Parcels~Basemaps_L3Parcels~|Detailed%20Features~Basemaps_MassG
ISBasemapWithLabels1~|Parcels%20Level%203%20No%20Roads%20for%20Query~massgis:GIS
DATA.L3_TAXPAR_POLY_ASSESS~Blank_Polys_Max_17100|NavTeq%20MA%20Other%20Streets%2
0for%20Query~massgis:GISDATA.NAVTEQRDS_ARC~Blank_Lines_Max_50000&bbox=-71.073813
35028504,42.436861512270944,-71.06514981516888,42.4391418865475&coordUnit=m&meas
ureUnit=m&base=MassGIS_Basemap¢er=-7911418.5007311,5226817.4674465&zoom=18&opac
ity=1,1,1,1,1&baseO=1&filt=undefined|undefined|undefined|undefined|undefined

When I switch to Bing Satellite the tilesets should continue to draw, they do 
not show any "!" but they don't draw:

http://maps.massgis.state.ma.us/map_ol_tile/oliver.php?lyrs=Structures~Basemaps_
Structures~|Tax%20Parcels~Basemaps_L3Parcels~|Detailed%20Features~Basemaps_MassG
ISBasemapWithLabels1~|Parcels%20Level%203%20No%20Roads%20for%20Query~massgis:GIS
DATA.L3_TAXPAR_POLY_ASSESS~Blank_Polys_Max_17100|NavTeq%20MA%20Other%20Streets%2
0for%20Query~massgis:GISDATA.NAVTEQRDS_ARC~Blank_Lines_Max_50000&bbox=-71.073813
35028504,42.436861512270944,-71.06514981516888,42.4391418865475&coordUnit=m&meas
ureUnit=m&base=bingAerial¢er=-7911418.5007311,5226817.4674465&zoom=18&opacity=1
,1,1,1,1&baseO=1&filt=undefined|undefined|undefined|undefined|undefined

I thought they did before, can we look into this? 

Original comment by Aleda.Fr...@state.ma.us on 11 Jan 2013 at 6:13

GoogleCodeExporter commented 9 years ago
The tilesets do draw on OpenStreetMap:

http://maps.massgis.state.ma.us/map_ol_tile/oliver.php?lyrs=Structures~Basemaps_
Structures~|Tax%20Parcels~Basemaps_L3Parcels~|Detailed%20Features~Basemaps_MassG
ISBasemapWithLabels1~|Parcels%20Level%203%20No%20Roads%20for%20Query~massgis:GIS
DATA.L3_TAXPAR_POLY_ASSESS~Blank_Polys_Max_17100|NavTeq%20MA%20Other%20Streets%2
0for%20Query~massgis:GISDATA.NAVTEQRDS_ARC~Blank_Lines_Max_50000&bbox=-71.073813
35028504,42.436861512270944,-71.06514981516888,42.4391418865475&coordUnit=m&meas
ureUnit=m&base=openStreetMap¢er=-7911418.5007311,5226817.4674465&zoom=18&opacit
y=1,1,1,1,1&baseO=1&filt=undefined|undefined|undefined|undefined|undefined

and they do draw on Google Road Map:

http://maps.massgis.state.ma.us/map_ol_tile/oliver.php?lyrs=Structures~Basemaps_
Structures~|Tax%20Parcels~Basemaps_L3Parcels~|Detailed%20Features~Basemaps_MassG
ISBasemapWithLabels1~|Parcels%20Level%203%20No%20Roads%20for%20Query~massgis:GIS
DATA.L3_TAXPAR_POLY_ASSESS~Blank_Polys_Max_17100|NavTeq%20MA%20Other%20Streets%2
0for%20Query~massgis:GISDATA.NAVTEQRDS_ARC~Blank_Lines_Max_50000&bbox=-71.073813
35028504,42.436861512270944,-71.06514981516888,42.4391418865475&coordUnit=m&meas
ureUnit=m&base=googleRoadmap¢er=-7911418.5007311,5226817.4674465&zoom=18&opacit
y=1,1,1,1,1&baseO=1&filt=undefined|undefined|undefined|undefined|undefined

They draw on every basemap except the Bing... what's different about Bing?  Of 
course it's the one we want the most. 

Original comment by Aleda.Fr...@state.ma.us on 11 Jan 2013 at 6:17

GoogleCodeExporter commented 9 years ago
Bing maps have a different starting zoom index from the rest of the world.  No 
surprise there.

See if r429 fixes this.

Original comment by cpl...@gmail.com on 11 Jan 2013 at 6:58

GoogleCodeExporter commented 9 years ago

Original comment by Aleda.Fr...@state.ma.us on 11 Jan 2013 at 7:03