MassOS-Linux / MassOS

Main source repository for the MassOS operating system.
https://massos.org
Other
97 stars 8 forks source link

[Bug]: [KVM] Locale and keyboard layout are not set to the selected value during the install #35

Closed lilian-pouliquen closed 2 years ago

lilian-pouliquen commented 2 years ago

Checklist

MassOS version

2022.06

Kernel version

Linux 5.18.1-massos #1 SMP PREEMPT_DYNAMIC Wed Jun 1 16:11:46 UTC 2022 x86_64

Subject

Expected Behavior

When installing MassOS with a specific keyboard layout and locale, the system should use these after rebooting when the installation is complete or after selecting it to avoid mistakes while creating root password and primary user.

Actual Behavior

Although the locale and keyboard layout are set to another language, the system and keyboard layout stay in English (QWERTY) after the selection and after the reboot.

Steps to reproduce

  1. Create a virtual machine run it attaching the massos-2022.06-x86_64.iso ISO to it (virt-manager xml sample attached)
  2. Run the VM and install MassOS
    • When selecting the locale and keyboard layout:
      • Choose fr_FR.UTF-8 as locale
      • Choose fr French as keyboard layout
  3. Continue the installation, during the next steps you will notice that the keyboard layout has not changed.
  4. Finish the installation and reboot the VM, you will notice that the system remained in English and the keyboard layout as well.

massos_kvm.txt

Additional Information

I noticed that if I change the keyboard layout in the settings (on the live CD demo, or after the installation), it only applies when I remove the English layout.

I tested out the installation with the following languages:

  1. French
    • locale: fr_FR.UTF-8
    • keyboard layout: fr French
  2. Russian
    • locale: ru_RU.UTF-8
    • keyboard layout: ru Russian
DanielMYT commented 2 years ago

Thanks for reporting this issue. Hopefully it should now be fixed in https://github.com/MassOS-Linux/livecd-installer/commit/5163465ffeda91499bff438f5ff4914339619ba8.

This fix will be included in the next MassOS release, however since it is part of the livecd-installer program on the Live CD, you should be able to apply the fix to the current version without needing to rebuild the ISO by running something like this in the terminal of the live environment (before running the installer as normal) (note that you will need to be connected to the internet):

curl -s https://github.com/MassOS-Linux/livecd-installer/commit/5163465ffeda91499bff438f5ff4914339619ba8.patch | sudo patch -d /usr/bin -Np1
lilian-pouliquen commented 2 years ago

Thanks for the patch. I confirm it is working on the virtual machine with French language.