Massdrop / mdloader

Massdrop Firmware Loader - for CTRL / ALT / SHIFT / Rocketeer keyboards
GNU General Public License v3.0
430 stars 79 forks source link

Add multiple Chip IDs to Resolve mdloader not working on old/new PCBs #37

Open CombatCables opened 4 years ago

CombatCables commented 4 years ago

https://github.com/Massdrop/mdloader/blob/fcef3c437e1c283ea6009435399ebfb2004b4c31/mdloader_common.c#L38

Further documentation can be found here to ultimately future proof this problem: http://ww1.microchip.com/downloads/en/DeviceDoc/SAM-D5x-E5x-Family-Silicon-Errata-DS80000748K.pdf

mcu_t mcus[] = {
      //Name,       Chip ID     Chip ID,    Program Memory, Data Memory,    Program Addr,   Data Addr
      //            Address                 (FLASH_SIZE)    (HSRAM_SIZE)    (FLASH_ADDR)    (HSRAM_ADDR)
    { "SAMD51J18A-0", 0x41002018, 0x60060006, 0x40000,        0x20000,        0x00000000,     0x20000000},
    { "SAMD51J19A-0", 0x41002018, 0x60060005, 0x40000,        0x20000,        0x00000000,     0x20000000},
    { "SAMD51J18A-3", 0x41002018, 0x60060306, 0x40000,        0x20000,        0x00000000,     0x20000000}, 
    { "SAMD51J19A-3", 0x41002018, 0x60060305, 0x40000,        0x20000,        0x00000000,     0x20000000}, 
};
JasonYuanLiu commented 4 years ago

There's also a chance it's 0x60060306 and 0x60060305, as seen in issue #24 and #32

CombatCables commented 4 years ago

There's also a chance it's 0x60060306 and 0x60060305, as seen in issue #24 and #32

Alright I added the other Chip IDs as well. It should work with all boards mentioned. Just need Drop to submit the update for qmk_toolbox to get updated