Drop FW Fixes for massdrop alt, ctrl, rocketeer & shift keyboards - Githubissues

Massdrop / qmk_firmware

keyboard controller firmware for Atmel AVR and ARM USB families

http://qmk.fm

GNU General Public License v2.0

89 stars 108 forks source link

Drop FW Fixes for massdrop alt, ctrl, rocketeer & shift keyboards #10

Closed pschmuckal closed 4 years ago

pschmuckal commented 4 years ago

In config.h of each, added '#define BOOTKEY_HOLD_MS 2000' to define hold time required to active Boot key (was 500ms hardcode)
Updated all active keymap.c files to use this define
Added line in quantum.c in MAGIC_TOGGLE_NKRO case to clear_keyboard() before toggling nkro state to fix stuck key issues when switching NKRO.

Description

Types of Changes

[ ] Core
[ ] Bugfix
[ ] New feature
[ ] Enhancement/optimization
[ ] Keyboard (addition or update)
[ ] Keymap/layout/userspace (addition or update)
[ ] Documentation

Issues Fixed or Closed by This PR

Checklist

[ ] My code follows the code style of this project.
[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.
[ ] I have added tests to cover my changes.
[ ] I have tested the changes and verified that they work and don't break anything (as well as I can manage).