Make the controllers performance better.

MassiGy / Camp-Shop

This is my second project, which is a small web app to find & review campgrounds (clone of yelpcamp)

https://camp-shop.up.railway.app/

5 stars 1 forks source link

Make the controllers performance better. #10

Open MassiGy opened 1 year ago

MassiGy commented 1 year ago

Hey there,

Currently the controllers performance can be improved. To do so, we will:

Remove all the unecessary awaits.
Remove all the unecessary mongo queries.
Use Promise.all and other Promise based methods to use parallel promise execution.

Kind regards.

ujwalkumar1995 commented 1 year ago

Hey @MassiGy I would like to work on this. I have gone through the controller level code on a high level. Seems we could use Promise.all at few places to optimize the performance. On first look I cannot find unnecessary awaits or mongo queries. If you have seen any example of unnecessary await or mongo queries, please do let me know. I will fix those as well as part of the PR.

MassiGy commented 1 year ago

Hey @ujwalkumar1995, hope that you are doing well.

Right now, I am also going through the code to optimize it. The best thing is to try your best to optimize it & then we will se what can we merge to production.

Kind regards.

MassiGy commented 1 year ago

Also, please structure your branches is this way: dev-username-feature