End length ratio 0 < alpha < 0.5

MassimoCimmino / pygfunction

An open-source toolbox for the evaluation of thermal response factors (g-functions) of geothermal borehole fields.

BSD 3-Clause "New" or "Revised" License

46 stars 21 forks source link

End length ratio 0 < alpha < 0.5 #159

Closed j-c-cook closed 3 years ago

j-c-cook commented 3 years ago

Should the end length ratio always fall within 0 < alpha < 0.5 or only for when nSegments==3?

https://github.com/MassimoCimmino/pygfunction/blob/50b54afe70ac6e670b0896d0afc8561d088e2637/pygfunction/utilities.py#L55-L57

MassimoCimmino commented 3 years ago

That is correct. The limit end_length_ratio < 0.5 should apply to all cases.

Also, in preparation for #159, we could consider here to allow nSegments=2 and nSegments=1 (which would simply return segment_ratios=numpy.array([0.5, 0.5]) and numpy.array([1.0])). A warning will be required in the case nSegments=2 to warn the user that the end_length_ratio parameter is overwritten.

@j-c-cook will you be working on this?

j-c-cook commented 3 years ago

Yes, put this high on my priority list.