search

MassimoCimmino / pygfunction

An open-source toolbox for the evaluation of thermal response factors (g-functions) of geothermal borehole fields.
BSD 3-Clause "New" or "Revised" License
46 stars 21 forks source link

Publish on release workflow #230

Closed j-c-cook closed 1 year ago

j-c-cook commented 2 years ago

Did version 2.2.0 never get pushed onto PyPi? Would you want to setup a publish on release workflow file? I remember thinking pre-releases don't trigger this workflow.

MassimoCimmino commented 2 years ago

This is odd. I am fairly certain I uploaded it and tested the installation using pip. I will upload it today.

A workflow file would definitely streamline the release process and avoid this kind of mistake in the future.

MassimoCimmino commented 2 years ago

I just published v2.2.0.

This issue can be used to implement the workflow. There will be some differences with ghedt since we do not have a setup.py file anymore for pygfunction.

MassimoCimmino commented 2 years ago

This looks like a good place to start : https://github.com/pypa/gh-action-pypi-publish

j-c-cook commented 2 years ago

This is odd. I am fairly certain I uploaded it and tested the installation using pip. I will upload it today.

A workflow file would definitely streamline the release process and avoid this kind of mistake in the future.

Perhaps PyPi had to roll back a version, lost some data in the process and you were lucky enough to get in at the wrong time. A workflow can't help with that, but most of the time should reduce some of the manual input required to get a release out.