search

Massive-Wiki / massivewikibuilder

Massive Wiki Builder
MIT License
3 stars 3 forks source link

Ampersand in a wiki link on the Sidebar leads to 404 on website #49

Open band opened 1 year ago

band commented 1 year ago

I had a link to a file with an "&" in the Obsidian file name on the Sidebar page. When website is built with mwb3 this link was not resolved to the actual page, but to a page name at the wiki root. When website is built with mwb (v2) the page is resolved and rendered correctly. Ampersands in other wiki page names do not cause mwb3 problems to links in the all-pages list or to pages returned by search.

I fixed my immediate problem by changing the file name, but will put some testing pages together on the developer wiki.

peterkaminski commented 1 year ago

Thanks for finding this, Bill!

band commented 1 year ago

I think I have a fix that will work for MWB (for now). (also cleaned up some un-needed code). PR or 1-1 code review?

peterkaminski commented 1 year ago

Either way, although my synchronous calendar is probably full until next week.

You could also just commit to main, if it's not anything crazy, since mwb3 is in limited release.

band commented 1 year ago

OK. I'll do the commit to main. I'll also bump the rel number in mwb3.py to 3.0.2. we can update the release info next week.

peterkaminski commented 9 months ago

@band, is it okay to close this ticket?

band commented 9 months ago

"yes!", since I do not remember having any problems since last May.