MassiveCraft / Factions

https://www.massivecraft.com/factions
245 stars 591 forks source link

Integration Activation IntegrationWorldGuard FAILED #1335

Open MinecraftMarcus1 opened 6 years ago

MinecraftMarcus1 commented 6 years ago

Affected Plugin

**Factions** **2.14.0** **No I did not forget.** **2.14.0** - **Affected Plugin Name:** **Factions** - **Affected Plugin Version:** **2.14.0** ## Describe your Environment

Steps to Reproduce this Bug

**There really isn't any bugs at least that I have seen or noticed it's just the constantly spamming error message in console.**
  1. N/A
  2. N/A
  3. N/A

Observed Results

**N/A** **N/A** ![screenshot 1](https://user-images.githubusercontent.com/26508255/47469761-348eb980-d7c8-11e8-8d7a-84a600a2b67e.png) **https://pastebin.com/kWwDYudJ** ## Expected Results **I didn't expect anything really except for it to keep on spamming console with the same error message.** **This is an issue because it constantly is spamming console with the same message making it nearly impossible to see anything else going on in console.**
macdja38 commented 6 years ago

This is probably caused due to the removal of a specific class in region-guard 7.0 https://www.spigotmc.org/threads/worldguard-and-factions-cant-integrate-1-13.331333/

Korinocho commented 5 years ago

Any way to solve this? Or im being forced to delete WorldGuard?

StormyIceLeopard commented 5 years ago

I think I might have a temporary fix Go to this link https://github.com/MassiveCraft/Factions/blob/master/src/com/massivecraft/factions/integration/worldguard/EngineWorldGuard.java

Then look at lines 44-55

@Override public void setActiveInner(boolean active) { if (active) { this.worldGuard = WGBukkit.getPlugin(); } else { this.worldGuard = null; } }

Replace with @Override public void setActiveInner(boolean active) { this.worldGuard = null; }

This will at the very least stop errors in console. (I think)

Korinocho commented 5 years ago

Will try when I get home. Thank :)

StormyIceLeopard commented 5 years ago

I created a pull request https://github.com/MassiveCraft/Factions/pull/1337

StormyIceLeopard commented 5 years ago

I have successfully created a version of Factions with no errors in console. Currently testing features.

1.13.2

StormyIceLeopard commented 5 years ago

So as far as I can tell it functions as intended without errors in console about Integration Activation IntegrationWorldGuard FAILED, but I don't do anything between it and WorldGuard. That you will have to discover on your own. Will update this reply with a link to download the compiled version that works. And no I didn't add anything, I only moved or removed code and changed 2 lines in plugin.yml

NO GUARANTEES THAT THIS IS BUG-FREE! LINK for 1.13.2 (tested) download: https://blizzardcraft.net/plugins/MassiveCraft/Factions/

Known issues: None as of Tuesday 11/27/2018 7:33 PM EST

macdja38 commented 5 years ago

@StormyIceLeopard any chance you could link the the source so I can verify and build it myself? Thanks.

StormyIceLeopard commented 5 years ago

No, because I did it myself. If you want to go through the hassle to build it yourself then just delete the WorldGuard Integrations Folder/class and build.

Good Luck.

EDIT: I also had to mess with the main: and name: fields in plugin.yml so it would load correctly in spigot.

macdja38 commented 5 years ago

@StormyIceLeopard I mean you could put it on GitHub as a fork even if you did it yourself, but do you mean you just removed all the worldGuard integration stuff or did you fix the worldGuard integration?

StormyIceLeopard commented 5 years ago

I can try. Going to sleep and got finals so maybe in a few days. If I remember correctly it's the worldguarditegration class that I deleted. It might have been a package with 2 classes inside it. I can tell you for certain within the next 24 hours.

StormyIceLeopard commented 5 years ago

I deleted these 2 classes and this folder that holds them. https://github.com/MassiveCraft/Factions/tree/master/src/com/massivecraft/factions/integration/worldguard

StormyIceLeopard commented 5 years ago

Here is a fork: https://github.com/StormyIceLeopard/Factions/tree/master/src/com/massivecraft/factions/integration

macdja38 commented 5 years ago

@StormyIceLeopard thank you very much!

MithrandirCraft commented 5 years ago

Same issue here.

DerekZil commented 5 years ago

So as far as I can tell it functions as intended without errors in console about Integration Activation IntegrationWorldGuard FAILED, but I don't do anything between it and WorldGuard. That you will have to discover on your own. Will update this reply with a link to download the compiled version that works. And no I didn't add anything, I only moved or removed code and changed 2 lines in plugin.yml

NO GUARANTEES THAT THIS IS BUG-FREE! LINK for 1.13.2 (tested) download: https://blizzardcraft.net/plugins/MassiveCraft/Factions/

Known issues: None as of Tuesday 11/27/2018 7:33 PM EST

Can you also fix the Faction's chat breaking all my custom chat plugins? I use DeluxeChat and it gets overwritten by Factions.

Can you just remove the chat code, or will that break it?

StormyIceLeopard commented 5 years ago

Can you also fix the Faction's chat breaking all my custom chat plugins? I use DeluxeChat and it gets overwritten by Factions.

Can you just remove the chat code, or will that break it?

I have no idea. That is above my paid grade. I'm about to start college so I won't have any time for the coming months. Sorry.

Kamilkime commented 5 years ago

Same issue here, I suppose Faction just doesn't have 1.13 support so it also doesn't have WG for 1.13 support

DerekZil commented 5 years ago

Can anyone upload a tab auto-complete updated version please?

KMiseckas commented 5 years ago

Just need replacing WGBukkit.getPlugin with WorldGuardPlugin.inst();