search

MassiveCraft / MassiveCore

https://www.massivecraft.com/massivecore
51 stars 110 forks source link

Add LICENSE File To Repo #258

Open NullOrNaN opened 8 years ago

NullOrNaN commented 8 years ago

As I mentioned in one of the recently closed PR's, this repo seems to be missing a license file.

According to @MarkehMe it should be LGPLv3, is this correct? I want to ensure that I send you a PR for the correct license file.

NullOrNaN commented 8 years ago

Frankly, you should have one on each repo as it's a different project/code base.

Also, I'm unsure why you closed this instead of simply replying, @ulumulu1510. as all that it was meant to do was to add you a license file for this repo. If you don't wish to have one so be it, but I strong encourage you to add one to all the repos instead of having it on just one of them.

RoboMWM commented 8 years ago

Thought it was MIT according to DBO?

ulumulu1510 commented 8 years ago

First of all, I'm terribly sorry for my first answer (as why I delted it). You are indeed correct, we are missing a license file in the repo. @MatthewM

@RoboMWM, your assumption is correct.

I see your issue now and again, I am sorry for the inconvenience.

I will go ahead and foreward the issue to Cayorion, as Licenses are chosen by him.

NullOrNaN commented 8 years ago

@ulumulu1510 thank you. I was a bit confused as to why Factions license was linked to instead of one in this repo. If I had missed it I'd have been like "oh, my bad!".

Do keep us posted on the progress of this please :)

oloflarsson commented 8 years ago

We are not going to pull a pull request where you add a license file. That seems very insecure and like bad practice. I might add the license myself soon. For now we have more important things to focus on.

NullOrNaN commented 8 years ago

@oloflarsson you should always check all PRs and their content before adding them. I'm not suggesting you blindly add it.. I was suggesting that a license be added to this repo.