search

MasterDevs / ChromeDevTools

.NET library to interact with the Chrome Debugger
MIT License
135 stars 90 forks source link

Update tooling and protocols #15

Closed georgiosd closed 7 years ago

georgiosd commented 7 years ago

Not sure why the check is failing, compiles fine here.

qmfrederik commented 7 years ago

It looks like it's related to the .NET Core tooling. I'll try to have a look at it later this week - ping me if you do not hear back from me.

georgiosd commented 7 years ago

Weird, I didn't change anything to the project itself.

georgiosd commented 7 years ago

Some of these changes are breaking but useful. If you'd like to keep backwards-compatibility, you're welcome to modify them - obvious, I know :)

qmfrederik commented 7 years ago

@georgiosd There are some merge conflicts because the code which supports optional attributes has been merged.

Could you rebase this against master and update the PR? You'll also need to re-generate the classes since optional attributes will now be marked properly.

georgiosd commented 7 years ago

Sorry for the delay, will try to get to it this week

georgiosd commented 7 years ago

Guys, apologies but I no longer have a need for this and very little time right now. You're welcome to merge the changes (as much or as little of) but unfortunately I can't spend more time on this right now...

qmfrederik commented 7 years ago

@georgiosd Thanks for the heads up! I'll probably have a look at this in the future, no promises though :)